Skip to content

Conversation

@ashoknayak777
Copy link
Contributor

No description provided.

@ashoknayak777 ashoknayak777 requested a review from abhibhaw March 1, 2024 09:36
@ashoknayak777 ashoknayak777 self-assigned this Mar 1, 2024
@ashoknayak777 ashoknayak777 changed the title doc: Doc for Lock Config doc: Lock Config Mar 1, 2024
@ashoknayak777 ashoknayak777 changed the title doc: Lock Config doc: Lock Deployment Config Mar 1, 2024
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. A suggestion to add this as reference at all the places in docs where we have discussed about deployment template / configs in doc. Example reference and its child pages

Copy link
Contributor

@uxarya-d uxarya-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ashoknayak777
Copy link
Contributor Author

This looks great. A suggestion to add this as reference at all the places in docs where we have discussed about deployment template / configs in doc. Example reference and its child pages

Done

Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashoknayak777 ashoknayak777 merged commit c49a6f2 into main Mar 4, 2024
@ashoknayak777 ashoknayak777 deleted the lock-config branch March 4, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants